target: mbedos5: Allow jerry_port_console and jerry_port_log to be overriden by user code #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
the
jerry-port
Member
|
LGTM |
…erriden by user code We're building a REPL (as user-space program) on top of mbedos5 target. For this I need to override the jerry_port_console and jerry_port_log functions from the REPL. This commit wraps these functions in an ifndef, so we can define macros to not include these files. JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
janjongboom
force-pushed
the
mbedos_override_console_and_log
branch
from
1a4da7c to
ed048e1
Compare
Contributor
Author
|
Rebased against upstream/master, no code changes. |
Member
|
@matthewelse @thegecko please check this patch |
Member
|
I will land this patch next Monday if there will be no objections. |
Contributor
|
@zherczeg, ok. LGTM |
Contributor
|
@zherczeg LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're building a REPL (as user-space program) on top of mbedos5 target. For this I need to override the jerry_port_console and jerry_port_log functions from the REPL. This commit wraps these functions in an ifndef, so we can define macros to not include these files.
JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
/cc @matthewelse @thegecko