Remove the inline flag of ArrayBuffer helper functions #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
reviewed
Dec 12, 2016
| * @return ecma_length_t, the length of the arraybuffer | ||
| */ | ||
| inline ecma_length_t __attr_pure___ __attr_always_inline___ | ||
| inline ecma_length_t __attr_pure___ |
Member
There was a problem hiding this comment.
Why the inline keyword is not removed?
related issue jerryscript-project#1468 JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang zidong.jiang@intel.com
tilmannOSG
changed the title
tilmannOSG
approved these changes
Dec 12, 2016
tilmannOSG
left a comment
tilmannOSG
left a comment
There was a problem hiding this comment.
LGTM, only minor changes in the commit message:
arraybuffer -> ArrayBuffer
funcs -> functions
The commit message can be changed during the merge (no need to update the PR), @zherczeg and @LaszloLango please don't forget this if you are merging :)
Contributor
|
LGTM, fixes the build error against mbedos5 target with GCC 4.9.3. |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue #1468
Latest GCC compiler will report an error when the inline function definition is in a different source file
so we remove the inline flag
JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang zidong.jiang@intel.com