target: mbedos5: Update generate_pins.py #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
LaszloLango
requested changes
Dec 16, 2016
Contributor
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
Please add "Fixes #1493" to the commit message too. LGTM after that.
…r querying targets, and use the new location of target PinNames.h file. Previously `make source/pins.cpp` just failed silently, and returned an empty file. Therefore using pin names from JS (`LED1`) would silently fail when building JerryScript against mbed OS 5.2.3. We missed this because it does not happen when you upgrade an existing mbed OS 5.1 project. Fixes jerryscript-project#1493. JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
janjongboom
force-pushed
the
fix_generate_pins
branch
from
c8fa29f to
a8b35c1
Compare
Contributor
Author
|
@LaszloLango Done ^ |
LaszloLango
approved these changes
Dec 16, 2016
LaszloLango
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to use the new Python API for querying targets, and use the new location of target PinNames.h file. Previously
make source/pins.cppjust failed silently, and returned an empty file. Therefore using pin names from JS (LED1) would silently fail when building JerryScript against mbed OS 5.2.3. We missed this because it does not happen when you upgrade an existing mbed OS 5.1 project.JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
@matthewelse @thegecko
Fix for #1493