target: mbedos5: Support for building on Windows #1522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2017
thegecko
approved these changes
Jan 11, 2017
Contributor
thegecko
left a comment
thegecko
left a comment
There was a problem hiding this comment.
LGTM (once build passes)
Member
|
This is the error: |
This patch allows users to build for the mbedos5 target on Windows (normal Windows and Cygwin). Also needs ARMmbed/mbed-js-gulp#14. JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
janjongboom
force-pushed
the
mbed_windows
branch
from
f1835e4 to
80c1a33
Compare
Contributor
Author
|
@zherczeg Ah, my VM had the wrong git email set. Rebased and re-committed. |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows users to build for the mbedos5 target on Windows (normal
Windows and Cygwin). Also needs
ARMmbed/mbed-js-gulp#14.
JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
/cc @thegecko