Skip to content

target: zephyr: Switch to MinSizeRel build type following mainline. #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2017
Merged

target: zephyr: Switch to MinSizeRel build type following mainline. #1527

merged 1 commit into from
Jan 16, 2017

Conversation

@pfalcon
Copy link
Contributor

@pfalcon pfalcon commented Jan 14, 2017

Fixes #1526.

JerryScript-DCO-1.0-Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org

@pfalcon
target: zephyr: Switch to MinSizeRel build type following mainline.
bf0f2f9 
Fixes jerryscript-project#1526.

JerryScript-DCO-1.0-Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org
@pfalcon pfalcon mentioned this pull request Jan 14, 2017
Closed
@robertsipka
Copy link
Contributor

robertsipka commented Jan 15, 2017

LGTM (informally)

LaszloLango
LaszloLango approved these changes Jan 16, 2017
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango added bug Undesired behaviour jerry-port Related to the port API or the default port implementation labels Jan 16, 2017
tilmannOSG
tilmannOSG approved these changes Jan 16, 2017
View reviewed changes
Copy link

@tilmannOSG tilmannOSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tilmannOSG tilmannOSG merged commit f1a8080 into jerryscript-project:master Jan 16, 2017
@zherczeg zherczeg mentioned this pull request Mar 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LaszloLango LaszloLango LaszloLango approved these changes

@tilmannOSG tilmannOSG tilmannOSG approved these changes

Assignees

No one assigned

Labels

bug Undesired behaviour jerry-port Related to the port API or the default port implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pfalcon @robertsipka @LaszloLango @tilmannOSG