Skip to content

Conversation

@LaszloLango
Copy link
Contributor

  • Fixed Doxygen issues
  • Updated Doxygen config
  • Added new script to test whether doxygen generation was successful or not
  • Added to Travis CI

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

@LaszloLango LaszloLango added development Feature implementation test Related to testing labels Jan 24, 2017
@jiangzidong
Copy link
Contributor

in ecma-typedarray-object.c, it is addtogroup ecmatypedarrayobject ECMA %TypedArray% object related routines
however in ecma-typedarray-object.h, the sentence is different addtogroup ecmatypedarrayobject ECMA typedarray object related routines

It should be same, and It is my mistake. I've fixed it in #1532

@LaszloLango
Copy link
Contributor Author

@jiangzidong I can wait for #1532. I should finish the review of it at first, but it's too big. :)

@jiangzidong
Copy link
Contributor

jiangzidong commented Jan 24, 2017

That's fine:) Maybe you should also modify the ecma-typedarray-object.h in your patch.

Sorry that I mistakenly saw your reply as I can NOT wait for ... ...

And I will try to separate the big patch into small ones next time.

@LaszloLango LaszloLango force-pushed the doxygen-dev branch 2 times, most recently from 1cc5cb9 to c13a810 Compare January 24, 2017 14:13
 * Fixed Doxygen issues
 * Updated Doxygen config
 * Added new script to test whether doxygen generation was successful or not
 * Added to Travis CI

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg
Copy link
Member

LGTM

@LaszloLango LaszloLango merged commit 107c058 into jerryscript-project:master Jan 31, 2017
@LaszloLango LaszloLango deleted the doxygen-dev branch February 10, 2017 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Feature implementation test Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants