Add new input validator API functions #1576
Conversation
|
LGTM (informally). |
LaszloLango
force-pushed
the
fix-issue-1549
branch
from
fbfedef to
1503d7d
Compare
jerry-core/jerry.c
Outdated
|
|
||
| if (!lit_is_utf8_string_valid ((lit_utf8_byte_t *) source_p, (lit_utf8_size_t) source_size)) | ||
| { | ||
| return ecma_raise_syntax_error (ECMA_ERR_MSG ("The input should be a valid UTF8 string.")); |
There was a problem hiding this comment.
Input must be a valid UTF-8 string.
jerry-core/jerry-snapshot.c
Outdated
| { | ||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we need this? jerry_parse_and_save_snapshot calls jerry_parse.
There was a problem hiding this comment.
Yes we do. It does not call jerry_parse. It calls parser_parse_script
There was a problem hiding this comment.
Perhaps this is really not needed anymore.
LaszloLango
force-pushed
the
fix-issue-1549
branch
from
1503d7d to
ca54bf4
Compare
|
I have been thinking about this in the weekend. Perhaps we should make this a runtime enable.disable feature, and do check for all functions which accepts utf8/cesu8 input. This patch is more like a workaround than a fix. |
LaszloLango
force-pushed
the
fix-issue-1549
branch
3 times, most recently
from
83b0356 to
3c1c77a
Compare
LaszloLango
changed the title
|
@zherczeg, @robertsipka I've updated the PR. Please review again. |
| - [jerry_get_utf8_string_length](#jerry_get_utf8_string_length) | ||
| - [jerry_is_utf8_string_valid](#jerry_is_utf8_string_valid) | ||
|
|
||
|
|
There was a problem hiding this comment.
Yes, we do. This is the style in the whole MD
docs/02.API-REFERENCE.md
Outdated
|
|
||
| ```c | ||
| bool | ||
| jerry_is_utf8_string_valid (const jerry_char_t *utf8_buf_p, /**< UTF-8 string */ |
There was a problem hiding this comment.
What do you think of jerry_is_valid_utf8_string? Somehow that is more natural to me.
There was a problem hiding this comment.
Good to me. Should we rename the internal functions too? lit_is_valid_utf8_string?
There was a problem hiding this comment.
At some point we should. If you wish you can do it in this patch.
There was a problem hiding this comment.
Ok, I'll do it in this patch.
jerry-core/jerry-snapshot.c
Outdated
| { | ||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Perhaps this is really not needed anymore.
docs/02.API-REFERENCE.md
Outdated
|
|
||
| **See also** | ||
|
|
||
| - [jerry_run_simple](#jerry_run_simple) |
There was a problem hiding this comment.
jerry_run_simple expects utf8 string, not cesu8
There was a problem hiding this comment.
Fixed, removed the reference from jerry_is_cesu8_string_valid
LaszloLango
force-pushed
the
fix-issue-1549
branch
2 times, most recently
from
cae38f4 to
755a1e8
Compare
| * @return true - if UTF-8 string is well-formed | ||
| * false - otherwise | ||
| */ | ||
| bool |
There was a problem hiding this comment.
Please rename this function as well (jerry_is_valid_utf8_string)
|
|
||
| /** | ||
| * Input validatator functions | ||
| */ |
docs/02.API-REFERENCE.md
Outdated
| - [jerry_object_property_foreach_t](#jerry_object_property_foreach_t) | ||
|
|
||
|
|
||
| # Input validatator functions |
| bool jerry_foreach_object_property (const jerry_value_t obj_val, jerry_object_property_foreach_t foreach_p, | ||
| void *user_data_p); | ||
|
|
||
| /** |
Fixes jerryscript-project#1549 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
fix-issue-1549
branch
from
755a1e8 to
70a562f
Compare
5 participants
Fixes #1549
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com