Add debugger support on nuttx-smt32f4 target #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
added
enhancement
robertsipka
force-pushed
the
stm32f4_debugger_support
branch
from
a666e1e to
b28347a
Compare
zherczeg
requested changes
Feb 17, 2017
| * Read source code into buffer. | ||
| * | ||
| * @return concatenated source files | ||
| * Returned value must be freed with jmem_heap_free_block if it's not NULL. |
targets/nuttx-stm32f4/jerry_main.c
Outdated
| size_t *out_source_size_p) | ||
| static const uint8_t * | ||
| read_file (const char *file_name, | ||
| size_t *out_size_p) |
Member
There was a problem hiding this comment.
Comments are needed for these arguments.
robertsipka
force-pushed
the
stm32f4_debugger_support
branch
from
b28347a to
db81b13
Compare
zherczeg
requested changes
Feb 20, 2017
targets/nuttx-stm32f4/jerry_main.c
Outdated
|
|
||
| fclose (file); | ||
| file = NULL; | ||
| jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Error: failed to open file: %s\n", file_name); |
targets/nuttx-stm32f4/jerry_main.c
Outdated
| if (fseek_status != 0) | ||
| { | ||
| jerry_port_log (JERRY_LOG_LEVEL_ERROR, "There's nothing to read\n"); | ||
| jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Failed to fseek fseek_status(%d)\n", fseek_status); |
targets/nuttx-stm32f4/jerry_main.c
Outdated
| if (script_len < 0) | ||
| { | ||
| jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Out of memory error\n"); | ||
| jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Failed to ftell script_len(%ld)\n", script_len); |
Member
There was a problem hiding this comment.
Failed to get the file size (error: %d)
targets/nuttx-stm32f4/jerry_main.c
Outdated
| rewind (file); | ||
|
|
||
| rewind (file); | ||
| uint8_t *buffer = jmem_heap_alloc_block (script_len); |
Member
There was a problem hiding this comment.
This variant cannot return with NULL. It is a good idea to use the other here.
Contributor
Author
There was a problem hiding this comment.
I'm not sure that I understand you correctly, but the jmem_heap_alloc_block can return with NULL if there is not enough memory. What do you mean 'other'?
Member
There was a problem hiding this comment.
void *jmem_heap_alloc_block (const size_t size);
void *jmem_heap_alloc_block_null_on_error (const size_t size);
The jmem_heap_alloc_block crashes on error.
Contributor
Author
There was a problem hiding this comment.
Ohh, I missed it, thanks! I've updated the PR.
robertsipka
force-pushed
the
stm32f4_debugger_support
branch
2 times, most recently
from
0185228 to
39da457
Compare
LaszloLango
approved these changes
Feb 21, 2017
Contributor
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
LGTM, after the comment fix
targets/nuttx-stm32f4/jerry_main.c
Outdated
| size_t *out_source_size_p) | ||
| static const uint8_t * | ||
| read_file (const char *file_name, /**< source code */ | ||
| size_t *out_size_p) /**< number of bytes successfully read from source */ |
Contributor
There was a problem hiding this comment.
/**< [out] number of bytes successfully read from source */
Using jerry_parse_named_resource to parse script and construct an EcmaScript function. The file name will also passed to this function which is used by the debugger to find the source code. Run the constructed EcmaScript function instead of using the simple jerry runner. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
stm32f4_debugger_support
branch
from
39da457 to
38b0f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using jerry_parse_named_resource to parse script and construct an EcmaScript function.
The file name will also passed to this function which is used by the debugger to find
the source code.
Run the constructed EcmaScript function instead of using the simple jerry runner.