Add a port setting to build script #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsipka
reviewed
Feb 21, 2017
tools/build.py
Outdated
| build_options.append('-DFEATURE_PROFILE=%s' % PROFILE) | ||
|
|
||
| build_options.append('-DFEATURE_DEBUGGER=%s' % arguments.jerry_debugger) | ||
| build_options.append('-DJERRY_DEBUGGER_PORT=%s' % arguments.jerry_debugger_port) |
Contributor
There was a problem hiding this comment.
set FEATURE_DEBUGGER_PORT here.
jerry-core/CMakeLists.txt
Outdated
| # Status messages | ||
| message(STATUS "FEATURE_CPOINTER_32_BIT " ${FEATURE_CPOINTER_32_BIT}) | ||
| message(STATUS "FEATURE_DEBUGGER " ${FEATURE_DEBUGGER}) | ||
| message(STATUS "FEATURE_DEBUGGER_PORT " ${JERRY_DEBUGGER_PORT}) |
Contributor
There was a problem hiding this comment.
${FEATURE_DEBUGGER_PORT}
jerry-core/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| # Debugger port | ||
| set(DEFINES_JERRY ${DEFINES_JERRY} JERRY_DEBUGGER_PORT=${JERRY_DEBUGGER_PORT}) |
Contributor
There was a problem hiding this comment.
${FEATURE_DEBUGGER_PORT}
polaroi8d
force-pushed
the
build_port
branch
from
725a12b to
3f88569
Compare
robertsipka
reviewed
Feb 21, 2017
tools/build.py
Outdated
| build_options.append('-DFEATURE_PROFILE=%s' % PROFILE) | ||
|
|
||
| build_options.append('-DFEATURE_DEBUGGER=%s' % arguments.jerry_debugger) | ||
| build_options.append('-DFEATURE_DEBUGGER_PORT=%s' % arguments.jerry_debugger_port) |
Contributor
There was a problem hiding this comment.
Use '%d' here instead '%s'.
polaroi8d
force-pushed
the
build_port
branch
from
890c715 to
05dfb55
Compare
Contributor
|
LGTM (informally) |
zherczeg
approved these changes
Feb 21, 2017
jerry-core/CMakeLists.txt
Outdated
| # Optional features | ||
| set(FEATURE_CPOINTER_32_BIT OFF CACHE BOOL "Enable 32 bit compressed pointers?") | ||
| set(FEATURE_DEBUGGER OFF CACHE BOOL "Enable JerryScript debugger?") | ||
| set(FEATURE_DEBUGGER_PORT "5001" CACHE STRING "Use default or other port number?") |
Member
There was a problem hiding this comment.
Set debugger port number (default: 5001).
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
polaroi8d
force-pushed
the
build_port
branch
from
05dfb55 to
d91727d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu