Fix several pylint warnings. #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
reviewed
Mar 14, 2017
tools/unicode_ranges.py
Outdated
| """ | ||
|
|
||
| for a, b in itertools.groupby(enumerate(i), lambda (x, y): y - x): | ||
| for _, b in itertools.groupby(enumerate(i), lambda (x, y): y - x): |
Contributor
There was a problem hiding this comment.
It's correct, a throwaway variable name to indicate that part of the result is being ignored.
Contributor
There was a problem hiding this comment.
But, I fixed these pylint warnings (unicode related warnings) in the #1623 PR.
Contributor
Author
There was a problem hiding this comment.
I thought that patch landed already :)
Fixed all of the remaining warnings in 'build.py', 'run-tests.py' and 'check-license.py'. Related issue: jerryscript-project#1600 JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
fix-pylint-warnings
branch
from
55b7362 to
882314c
Compare
Contributor
|
LGTM (informally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all of the remaining warnings in 'build.py', 'run-tests.py' and 'check-license.py'.
Related issue: #1600
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com