Skip to content

Rename 'CONFIG_DISABLE_TYPEDARRAY_BUILTIN' to 'CONFIG_DISABLE_ES2015_… #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2017
Merged

Rename 'CONFIG_DISABLE_TYPEDARRAY_BUILTIN' to 'CONFIG_DISABLE_ES2015_… #1683

merged 1 commit into from
Mar 24, 2017

Conversation

@polaroi8d
Copy link
Contributor

@polaroi8d polaroi8d commented Mar 23, 2017

…TYPEDARRAY_BUILTIN'

JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu

Rename 'CONFIG_DISABLE_TYPEDARRAY_BUILTIN' to 'CONFIG_DISABLE_ES2015_…
4376505 
…TYPEDARRAY_BUILTIN'

JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
@jiangzidong
Copy link
Contributor

jiangzidong commented Mar 24, 2017

Hi @polaroi8d , there is also macro CONFIG_DISABLE_ARRAYBUFFER_BUILTIN for es2015. Do you plan to change its name in next PR?

@LaszloLango LaszloLango added the ES2015 Related to ES2015 features label Mar 24, 2017
@polaroi8d
Copy link
Contributor Author

polaroi8d commented Mar 24, 2017

@jiangzidong Sure.

jiangzidong
jiangzidong approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@jiangzidong jiangzidong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akosthekiss
akosthekiss approved these changes Mar 24, 2017
View reviewed changes
Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LaszloLango
LaszloLango approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit f501931 into jerryscript-project:master Mar 24, 2017
@polaroi8d polaroi8d mentioned this pull request Mar 24, 2017
Merged
@polaroi8d polaroi8d deleted the rename_es2015 branch March 27, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akosthekiss akosthekiss akosthekiss approved these changes

@LaszloLango LaszloLango LaszloLango approved these changes

+1 more reviewer

@jiangzidong jiangzidong jiangzidong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ES2015 Related to ES2015 features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@polaroi8d @jiangzidong @akosthekiss @LaszloLango