Add Exception handler to remote debugger #1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
reviewed
Mar 28, 2017
| typedef struct | ||
| { | ||
| uint8_t type; /**< type of the message */ | ||
| uint8_t enable; /**< non-zero: enable stop at exception */ |
Contributor
There was a problem hiding this comment.
Is this a boolean value? The description is not obvious to me.
zherczeg
approved these changes
Mar 28, 2017
Member
zherczeg
left a comment
zherczeg
left a comment
There was a problem hiding this comment.
LGTM after some minor changes.
jerry-core/debugger/jerry-debugger.c
Outdated
| if (exception_config_p->enable == 0) | ||
| { | ||
| JERRY_CONTEXT (debugger_flags) = (uint8_t) (JERRY_CONTEXT (debugger_flags) | ||
| | JERRY_DEBUGGER_VM_IGNORE_EXCEPTION); |
Member
There was a problem hiding this comment.
I don't think this is the right style. Add a local variable if the line is too long.
LaszloLango
requested changes
Mar 28, 2017
tests/debugger/do_exception.js
Outdated
| print("exception handler configuration test") | ||
|
|
||
| function foo() { | ||
| try { |
Contributor
There was a problem hiding this comment.
Please don't use tab characters
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
polaroi8d
force-pushed
the
exception_handler
branch
from
6fdea39 to
849dc69
Compare
Contributor
Author
|
@LaszloLango @zherczeg Updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In initial state the exception handler is enable. Use the
exceptioncommand with the 0 to disable the feature and 1 to enable it. Modified thehelpcommand test too.JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu