Fix several pylint warning in debugger python client #1704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polaroi8d
force-pushed
the
pep8_debugger
branch
3 times, most recently
from
e30b4b7 to
d4bc0d1
Compare
robertsipka
reviewed
Mar 30, 2017
|
|
||
| def disable_args(self, args): | ||
| if args != "": | ||
| print("Error: No argument expected") |
Contributor
There was a problem hiding this comment.
You can use this form: if args:
jerry-debugger/jerry-client-ws.py
Outdated
| if args != "": | ||
| print("Error: No argument expected") | ||
| return True | ||
| else: |
Contributor
There was a problem hiding this comment.
The else statement is unnecessary, you could return with false at the end of the function.
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
polaroi8d
force-pushed
the
pep8_debugger
branch
from
d4bc0d1 to
2a6c34f
Compare
zherczeg
reviewed
Mar 31, 2017
| self.idx_format = "I" | ||
|
|
||
| logging.debug("Compressed pointer size: %d" % (self.cp_size)) | ||
| logging.debug("Compressed pointer size: %d", self.cp_size) |
Member
There was a problem hiding this comment.
What is the problem with this?
Contributor
Author
There was a problem hiding this comment.
There is no problem, but this is the PEP8 logging standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu