Skip to content

Add GitHub ribbon to header.html #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2017
Merged

Add GitHub ribbon to header.html #1712

merged 1 commit into from
Apr 7, 2017

Conversation

@polaroi8d
Copy link
Contributor

@polaroi8d polaroi8d commented Apr 4, 2017

JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu

Add GitHub ribbon to index.html
bb8d733 
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
@polaroi8d polaroi8d changed the title Add GitHub ribbon to index.html Add GitHub ribbon to header.html Apr 4, 2017
@robertsipka
Copy link
Contributor

robertsipka commented Apr 4, 2017

LGTM (informally)

zherczeg
zherczeg approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg
Copy link
Member

zherczeg commented Apr 4, 2017

(Do not land it early, please give some time to people to check it).

@polaroi8d
Copy link
Contributor Author

polaroi8d commented Apr 4, 2017

Check the results in https://polaroi8d.github.io/jerryscript/

@polaroi8d polaroi8d mentioned this pull request Apr 5, 2017
Closed
LaszloLango
LaszloLango approved these changes Apr 6, 2017
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 957bd3e into jerryscript-project:gh-pages Apr 7, 2017
@polaroi8d polaroi8d deleted the ribbon-gh-pages branch April 11, 2017 07:24
@zherczeg zherczeg mentioned this pull request Mar 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zherczeg zherczeg zherczeg approved these changes

@LaszloLango LaszloLango LaszloLango approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@polaroi8d @robertsipka @zherczeg @LaszloLango