Split unit tests into separate directories #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit tests should follow the component structure, so this patch moves all `jerry-core` unit tests under `tests/unit-core` and the `jerry-libm` unit tests under `tests/unit-libm`. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
Member
Author
|
This PR also aims at paving the way for |
akosthekiss
added a commit
to akosthekiss/jerryscript
that referenced
this pull request
Apr 22, 2017
In jerryscript-project#1761, not all unit test paths have been updated in check tools. This triggers no errors as `check-vera` emits a warning only while `check-cppcheck` signals nothing. Still, this means that some of the code in the repository that has been quality-assured, is now avoiding checks. This patch fixes this. Moreover, `check-cppcheck` has had incorrect paths for a while: it looked for source files in the root of the repository, but those files have been in `jerry-main` for almost a year now. This patch fixes this, too. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
akosthekiss
added a commit
to akosthekiss/jerryscript
that referenced
this pull request
Apr 22, 2017
In jerryscript-project#1761, not all unit test paths have been updated in check tools. This triggers no errors as `check-vera` emits a warning only while `check-cppcheck` signals nothing. Still, this means that some of the code in the repository that has been quality-assured, is now avoiding checks. This patch fixes this. Moreover, `check-cppcheck` has had incorrect paths for a while: it looked for source files in the root of the repository, but those files have been in `jerry-main` for almost a year now. This patch fixes this, too. Fallout of the above: `main-unix-minimal.c` had to be improved to make `check-cppcheck` pass. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
yichoi
pushed a commit
that referenced
this pull request
Apr 24, 2017
In #1761, not all unit test paths have been updated in check tools. This triggers no errors as `check-vera` emits a warning only while `check-cppcheck` signals nothing. Still, this means that some of the code in the repository that has been quality-assured, is now avoiding checks. This patch fixes this. Moreover, `check-cppcheck` has had incorrect paths for a while: it looked for source files in the root of the repository, but those files have been in `jerry-main` for almost a year now. This patch fixes this, too. Fallout of the above: `main-unix-minimal.c` had to be improved to make `check-cppcheck` pass. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests should follow the component structure, so this patch
moves all
jerry-coreunit tests undertests/unit-coreand thejerry-libmunit tests undertests/unit-libm.JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu