Add strtol to jerry-libc and make use of it in jerry-main #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
enhancement
zherczeg
reviewed
Jun 23, 2017
jerry-libc/jerry-libc.c
Outdated
|
|
||
| const char *str = nptr; | ||
|
|
||
| /* Skip leading whitespace */ |
jerry-libc/jerry-libc.c
Outdated
| str++; | ||
| } | ||
|
|
||
| /* Process base-10 digits */ |
| } | ||
|
|
||
| /* Set endptr and return result*/ | ||
| if (digits) |
Member
Author
|
updated according to the review and rebased onto latest master |
zherczeg
approved these changes
Jun 26, 2017
jerry-libc/jerry-libc.c
Outdated
| int base) /**< numerical base or radix (MUST be 10) */ | ||
| { | ||
| assert (base == 10); | ||
| (void) base; /* unused */ |
As a side effect, refactor the variable types in `print_unhandled_exception` to reduce the overuse of sized integer types (generic `unsigned int` is better than `uint32_t` if there is no actual requirement on integer width). JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
yichoi
pushed a commit
that referenced
this pull request
Jul 19, 2017
Artik053 board is publicly announced about one month ago. So I updated tizenrt-artik05x reference board from sidk_s5jt200 to artik053. Now, tizenrt-artik05x port works with latest TizenRT repo on artik053 board. Also, I replaced str_to_uint to strtol since #1891 is landed. JerryScript-DCO-1.0-Signed-off-by: Sanggyu Lee sg5.lee@samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect, refactor the variable types in
print_unhandled_exceptionto reduce the overuse of sized integertypes (generic
unsigned intis better thanuint32_tif there isno actual requirement on integer width).
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu