Modify the build method of TizenRT target #2164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: the patch also removes unused/unnecessary codes. |
Contributor
|
Nice patch! Could you please also update the README with the followings:
LGTM (informally) after these minor fixes. |
Contributor
|
@robertsipka I already updated for second item in #2128. |
Contributor
|
@glistening : Indeed, I missed that, thanks. |
Introduced a cmake/toolchain_mcu_artik053.cmake file that defines all the target specific compiler options. Modified the Makefile.tizenrt to do not copy the created static libraries to the TizenRT folder. Instead, the application builder Makefile (tizenrt-artik053/apps/jerryscript/Makefile) copies the required static libraries to TizenRT. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
rtakacs
force-pushed
the
tizenrt-toolchain-file
branch
from
5ac7ea3 to
9652424
Compare
Contributor
Author
|
@robertsipka I've updated the README.md according to your requirements. |
Contributor
Author
|
@hs0225 Could you try out this PR on ARTIK053? |
Contributor
Contributor
Author
|
@glistening Yes, I've already tested this PR on ARTIK053 (just build and flash, and run jerry with no test). It worked for me, so maybe it's enough just to check the modifications. |
Contributor
|
LGTM (as a maintainer of TizenRT port) |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a cmake/toolchain_mcu_artik053.cmake file that defines all the target specific compiler options.
Modified the Makefile.tizenrt to do not copy the created static libraries to the TizenRT folder. Instead, the application builder Makefile (tizenrt-artik053/apps/jerryscript/Makefile) copies the
required static libraries to TizenRT.
This modification helps to build JerryScript with the Python based build-script. In this case the user can use more build options.
tools/build.py \ --clean \ --lto=OFF \ --jerry-cmdline=OFF \ --all-in-one=OFF \ --jerry-libc=OFF \ --mem-heap=70 \ --profile=es2015-subset \ --toolchain=${PWD}/cmake/toolchain_mcu_artik053.cmake \ --compile-flag="--sysroot=${PWD}/../TizenRT/os"