Skip to content

Conversation

@LaszloLango
Copy link
Contributor

@LaszloLango LaszloLango commented Feb 16, 2018

It is a followup fix after #2169. It also fixes a memory leak.
This fixes #2198 and fixes #2204

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

It is a followup fix after jerryscript-project#2169. It also fixes a memory leak.
This fixes jerryscript-project#2198 and fixes jerryscript-project#2204

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi
Copy link
Contributor

yichoi commented Feb 19, 2018

LGTM

@yichoi yichoi merged commit 6fce323 into jerryscript-project:master Feb 19, 2018
grgustaf pushed a commit to grgustaf/jerryscript that referenced this pull request Mar 19, 2018
It is a followup fix after jerryscript-project#2169. It also fixes a memory leak.
This fixes jerryscript-project#2198 and fixes jerryscript-project#2204

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
@LaszloLango LaszloLango deleted the fix-regression-2204 branch May 10, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ecma builtins Related to ECMA built-in routines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion 'qmin <= qmax' failed in re_insert_simple_iterator Assertion 'ECMA_STRING_IS_REF_EQUALS_TO_ONE (string_p)' failed in ecma_free_string_list

3 participants