Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 20, 2018

Added negative tests

JerryScript-DCO-1.0-Signed-off-by: Balint Sipos siposb@inf.u-szeged.hu

@LaszloLango
Copy link
Contributor

typo in the filename: tests/jerry/arguments-pharse.js -> tests/jerry/arguments-parse.js

check_parse_error("f_args 1,2,3)");
check_parse_error("f_args 1,2,3");
check_parse_error("f_args 1;2;3");
check_parse_error("f_args{1,2,3}"); No newline at end of file
Copy link
Contributor

@robertsipka robertsipka Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at the end of the file and use two spaces for indents

parse("a =% b");

parse("c = a+");
parse("c = a-"); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

parse(forIn)



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much new line here.

var doubleFor2 =
"for(i=0;i<5;i++) { "+
" for(j=0;j<5;j++) { print('i: '+i+' j: '+j)";
parse(doubleFor2) No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

"if (false) print('if statement') " +
"else (false) print('else if statement') " +
"else print('else statement') "
test_parse_error(elseif3) No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Added negative tests

JerryScript-DCO-1.0-Signed-off-by: Balint Sipos siposb@inf.u-szeged.hu
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit ccc2832 into jerryscript-project:master Feb 28, 2018
grgustaf pushed a commit to grgustaf/jerryscript that referenced this pull request Mar 19, 2018
JerryScript-DCO-1.0-Signed-off-by: Balint Sipos siposb@inf.u-szeged.hu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants