Support large string constants in 32 bit cpointer mode. #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this patch, all sunspider tests run when cpointer 32 is enabled. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
galpeter
reviewed
Mar 2, 2018
| * Limit: PARSER_MAXIMUM_STRING_LIMIT. */ | ||
| #ifndef PARSER_MAXIMUM_STRING_LENGTH | ||
| #define PARSER_MAXIMUM_STRING_LENGTH 65535 | ||
| #define PARSER_MAXIMUM_STRING_LENGTH PARSER_MAXIMUM_STRING_LIMIT |
Contributor
There was a problem hiding this comment.
If it is the same as the other define, do we need it at all?
Member
Author
There was a problem hiding this comment.
Yes, because the maximum is the default configuration, although we allow lower values.
grgustaf
pushed a commit
to grgustaf/jerryscript
that referenced
this pull request
Mar 19, 2018
…project#2233) After this patch, all sunspider tests run when cpointer 32 is enabled. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this patch, all sunspider tests run when cpointer 32 is enabled.