Skip to content

Conversation

@rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Mar 5, 2018

The error value is released in the print_unhandled_exception function, however
that value is used and released later.

The error value is released in the print_unhandled_exception function, however
that value is used and released later. This patch fixes this bug.

JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka
Copy link
Contributor

LGTM (informally)

@rtakacs
Copy link
Contributor Author

rtakacs commented Mar 5, 2018

Note: the expected fail tests cause arm_dataabort on artik053 without this patch.

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 29b337d into jerryscript-project:master Mar 6, 2018
grgustaf pushed a commit to grgustaf/jerryscript that referenced this pull request Mar 19, 2018
…rryscript-project#2235)

The error value is released in the print_unhandled_exception function, however
that value is used and released later. This patch fixes this bug.

JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
@rtakacs rtakacs deleted the fix-error-value branch January 18, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants