Move the sleep function to jerry-port #2245
Conversation
imiklos
force-pushed
the
sleep
branch
2 times, most recently
from
009332f to
e78e6c9
Compare
jerry-port/default/default-date.c
Outdated
|
|
||
| #ifdef JERRY_DEBUGGER | ||
| #include <jrt.h> | ||
|
|
There was a problem hiding this comment.
You've added this include twice. Remove from here.
There was a problem hiding this comment.
why is jrt.h required in default-date.c at all? that seems like a layering violation to me. if that's only for the sake of uint32_t, there are standard libc headers that could be included.
jerry-port/default/default-date.c
Outdated
|
|
||
| #ifdef JERRY_DEBUGGER | ||
| #include <jrt.h> | ||
|
|
There was a problem hiding this comment.
why is jrt.h required in default-date.c at all? that seems like a layering violation to me. if that's only for the sake of uint32_t, there are standard libc headers that could be included.
| */ | ||
| #ifdef JERRY_DEBUGGER | ||
| void jerry_port_sleep (uint32_t sleep_time); | ||
| #endif /* JERRY_DEBUGGER */ |
There was a problem hiding this comment.
this is outside the comment group. should be within.
|
@robertsipka @akosthekiss Thank you for the reviews. I updated the PR. |
Now the jerry-debugger uses the jerry-port's sleep, therefore if there are systems that don't support usleep or nanosleep can now define their own function. JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu
|
@LaszloLango Thank you for the review. Moved the port function to a new file and updated the |
|
LGTM |
| struct jerry_instance_t *jerry_port_get_current_instance (void); | ||
|
|
||
| /** | ||
| * Makes the process sleep for a given time. |
There was a problem hiding this comment.
The unit of time is millisecond.
6 participants
Now the jerry-debugger uses the jerry-port's sleep, therefore if there are systems that don't support
usleep or nanosleep they can now define their own function.
JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu