Skip to content

Conversation

@imiklos
Copy link
Contributor

@imiklos imiklos commented Jul 2, 2018

This patch fixes the #2383 issue

JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu


while ((substr_size = jerry_substring_to_char_buffer (str_val,
while ((substr_size = jerry_substring_to_utf8_char_buffer (str_val,
substr_pos,
Copy link
Contributor

@LaszloLango LaszloLango Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have fixed the indentation and updated the PR.

This patch fixes the jerryscript-project#2383 issue

JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu
@imiklos imiklos force-pushed the fix_json_stringify branch from 35c1873 to 79e339a Compare July 2, 2018 09:49
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yichoi yichoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit 0c6b5ea into jerryscript-project:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants