Skip to content

Conversation

@akosthekiss
Copy link
Member

This means cross building with clang and using short enums. Also
bump RIOT OS version to latest 2018.07.

Note: On Travis CI, clang-3.9 is used for testing. That version is
widely available, from Ubuntu 14.04 to 18.04.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

@akosthekiss
Copy link
Member Author

Related to and pending on #2473 : this PR will have to be rebased onto master when that one lands (right now, I've cherry-picked the fixes from that PR to make things build).

cc @miri64 : this PR may help the "developers wont have easy ways to detect the need for such casts" issue on the long run.

And all this also means that we may finally have a clang build test on the CI.

@miri64
Copy link
Contributor

miri64 commented Aug 17, 2018

Cool! However, the current configuration makes it seem like RIOT is exclusively built with clang. I want to point out that this isn't the case. We are just currently hardening our clang support ;-).

@akosthekiss
Copy link
Member Author

Thanks for the feedback. Duly noted. I'll put some extra words into the commit message to make that clear.

@akosthekiss akosthekiss force-pushed the riot-clang-short-enums branch from feb35da to 9d63e52 Compare August 18, 2018 00:20
@akosthekiss akosthekiss changed the title [WIP] Bring build of the RIOT target closer to the RIOT OS build setup [WIP] Align the RIOT target with the clang build of RIOT OS Aug 18, 2018
This means cross building with clang and using short enums. Also
bump RIOT OS version to latest 2018.07.

Note: On Travis CI, clang-3.9 is used for testing. That version is
widely available, from Ubuntu 14.04 to 18.04.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@akosthekiss akosthekiss force-pushed the riot-clang-short-enums branch from 9d63e52 to bf1d509 Compare August 21, 2018 07:35
@akosthekiss akosthekiss changed the title [WIP] Align the RIOT target with the clang build of RIOT OS Align the RIOT target with the clang build of RIOT OS Aug 21, 2018
@akosthekiss
Copy link
Member Author

Now that #2473 has landed, the PR is rebased onto latest master. It's ready for review.

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosthekiss akosthekiss merged commit 6e94414 into jerryscript-project:master Aug 21, 2018
@akosthekiss akosthekiss deleted the riot-clang-short-enums branch August 21, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants