Add RegExp recursion depth limit #2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
IMHO this limit should be applied to |
zherczeg
reviewed
Oct 1, 2018
imiklos
force-pushed
the
regexp_recursion_limit
branch
from
79d9642 to
1c5ca4a
Compare
zherczeg
reviewed
Oct 2, 2018
imiklos
force-pushed
the
regexp_recursion_limit
branch
2 times, most recently
from
e6f4c2a to
0e8ff57
Compare
Contributor
Author
|
@zherczeg @LaszloLango I've applied the first version of the patch and updated the PR. |
imiklos
force-pushed
the
regexp_recursion_limit
branch
from
0e8ff57 to
25de724
Compare
akosthekiss
reviewed
Oct 18, 2018
imiklos
force-pushed
the
regexp_recursion_limit
branch
from
25de724 to
da1149a
Compare
Contributor
Author
|
@LaszloLango @zherczeg @akosthekiss I've updated the PR. |
zherczeg
reviewed
Oct 19, 2018
zherczeg
reviewed
Oct 19, 2018
imiklos
force-pushed
the
regexp_recursion_limit
branch
6 times, most recently
from
d271448 to
5c82a89
Compare
imiklos
force-pushed
the
regexp_recursion_limit
branch
3 times, most recently
from
559750e to
f8235f2
Compare
akosthekiss
requested changes
Oct 26, 2018
imiklos
force-pushed
the
regexp_recursion_limit
branch
2 times, most recently
from
4b1a08c to
59659c0
Compare
rerobika
requested changes
Nov 24, 2018
Member
imiklos
force-pushed
the
regexp_recursion_limit
branch
2 times, most recently
from
9583c51 to
fb04ecb
Compare
akosthekiss
requested changes
Dec 12, 2018
Member
akosthekiss
left a comment
akosthekiss
left a comment
There was a problem hiding this comment.
Some quick style change requests.
imiklos
force-pushed
the
regexp_recursion_limit
branch
from
fb04ecb to
355963f
Compare
Contributor
Author
|
@akosthekiss @rerobika Thank you! I've fixed the typos, style issues and updated the PR. |
imiklos
force-pushed
the
regexp_recursion_limit
branch
2 times, most recently
from
b62104e to
f3a3d35
Compare
akosthekiss
reviewed
Dec 17, 2018
imiklos
force-pushed
the
regexp_recursion_limit
branch
from
f3a3d35 to
89f26c2
Compare
rerobika
requested changes
Jan 2, 2019
imiklos
force-pushed
the
regexp_recursion_limit
branch
from
89f26c2 to
098afb5
Compare
Member
|
@akosthekiss Do you have any more comments, remarks about this PR? |
akosthekiss
requested changes
Jan 16, 2019
Member
The regexp engine does not have any recursion depth check, thus it can cause problems with various regexps. Added a new build option `--regexp-recursion-limit N` whose default value is 0, which is for unlimited recursion depth. Also added a build-option-test. Fixes jerryscript-project#2448 Fixes jerryscript-project#2190 JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu
imiklos
force-pushed
the
regexp_recursion_limit
branch
from
098afb5 to
ebf605f
Compare
Contributor
Author
|
@akosthekiss I updated the PR with the requested changes, also updated the commit message, as you mentioned, this PR also fixes the #2190. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regexp engine does not have any recursion depth check, thus it can cause problems with various regexps. Added a new build option
--regexp-recursion-limit Nwhosedefault value is 0, which is for unlimited recursion depth. Also added a build-option-test.
Fixes #2448
Fixes #2190
JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu