Increase test coverage: Array.prototype.indexOf #2685
Conversation
| } | ||
|
|
||
| // Checking behavior when values are unable to find | ||
| try{ |
|
|
||
| // Checking behavior when values are unable to find | ||
| try{ | ||
| var a = [undefined,undefined,undefined,undefined,undefined]; |
| try{ | ||
| var a = [undefined,undefined,undefined,undefined,undefined]; | ||
| for(var i=0; i<a.length; i++) | ||
| {delete a[i];} |
There was a problem hiding this comment.
Spaces around =, <, moreover:
for (...) {
//...
}| var a = [undefined,undefined,undefined,undefined,undefined]; | ||
| for(var i=0; i<a.length; i++) | ||
| {delete a[i];} | ||
| a.indexOf("bar"); |
| for(var i=0; i<a.length; i++) | ||
| {delete a[i];} | ||
| a.indexOf("bar"); | ||
| } catch (e) { } |
There was a problem hiding this comment.
assert (e instanceof TypeError)
| } catch (e) { } | ||
|
|
||
| // Checking behavior when value is null | ||
| try{ |
| try { | ||
| var a = [0, 1, 2, 3, 4]; | ||
| Object.defineProperty(a, '0', { 'get' : function () { throw new ReferenceError; } }); | ||
| Array.prototype.indexOf.call(a, "bar") |
| a.indexOf("bar"); | ||
| } catch (e) { } | ||
|
|
||
| // Checking behavior when value is null |
There was a problem hiding this comment.
// Checking behavior when this value is not coercible to object.
| assert (e instanceof ReferenceError); | ||
| } | ||
|
|
||
| // checking behavior when unable to get the first element |
Branch coverage: Before: 22/26 After: 26/26 JerryScript-DCO-1.0-Signed-off-by: Mate Dabis mdabis@inf.u-szeged.hu
|
Corrected |
| for (var i = 0; i < a.length; i++) { | ||
| delete a[i]; | ||
| } | ||
| a.indexOf("bar"); |
| Array.prototype.indexOf.call(a, function () { }); | ||
| assert(false); | ||
| } catch (e) { | ||
| assert(e instanceof ReferenceError); |
| Array.prototype.indexOf.call(a, "bar"); | ||
| assert(false); | ||
| } catch (e) { | ||
| assert(e instanceof ReferenceError); |
|
@matedabis Could you please give details similar to those requested at #2674 (comment) . I.e., which source file(s) or source file entity(-ies) (function(s)) are investigated, and what is the coverage result when all test suites of the project are executed (i.e., what is the actual baseline)? |
|
@akosthekiss |
akosthekiss
left a comment
akosthekiss
left a comment
There was a problem hiding this comment.
I'd like to have this on hold until validity questions are sorted out at #2674 .
|
Closing pull request because the updated version of the coverage tester script wich runs |
3 participants
Branch coverage:
Before: 22/26
After: 26/26
JerryScript-DCO-1.0-Signed-off-by: Mate Dabis mdabis@inf.u-szeged.hu