Skip to content

Conversation

@rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Jan 17, 2019

Added missing parentheses and explicit type conversions.

This is a fix for a bug that was mentioned at #2969.

Added missing parentheses and explicit type conversions.

JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
@rtakacs rtakacs force-pushed the fix-type-conversions branch from 7b01cf7 to 918f37e Compare January 17, 2019 09:30
@rtakacs rtakacs changed the title Fix some type conversions in ecma-objects. Fix some type conversions in ecma-builtins. Jan 17, 2019
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM (informal)

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 0b3d5ed into jerryscript-project:master Jan 17, 2019
@rtakacs rtakacs deleted the fix-type-conversions branch January 18, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants