Skip to content

Use logical operators for bool converions. #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

Use logical operators for bool converions. #2707

merged 1 commit into from
Jan 17, 2019

Conversation

@rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Jan 17, 2019

Replaced the newly introduced explicit boolean conversions to logical operators.

Reasons:

  • to be the boolean type conversion consistent in JerryScript
  • fix object-get-own-property-symbols test on NuttX and TizenRT

Use logical operators for bool converions.
14503ea 
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
rerobika
rerobika approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

akosthekiss
akosthekiss approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika
Copy link
Member

rerobika commented Jan 17, 2019

Side note for the object-get-own-property-symbols fail:

The original code assumed that after const bool is_symbols_only = (const bool) (opts & ECMA_LIST_SYMBOLS); initialization the value of is_symbols_only is 0/1 but in NuttX and TizenRT the value of is_symbols_only is ECMA_LIST_SYMBOLS(8). Due to that this comparison failed.

@akosthekiss akosthekiss merged commit 162e2dd into jerryscript-project:master Jan 17, 2019
LaszloLango
LaszloLango reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtakacs rtakacs deleted the use-logical-operators branch January 18, 2019 14:28
@zherczeg zherczeg mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LaszloLango LaszloLango LaszloLango left review comments

@akosthekiss akosthekiss akosthekiss approved these changes

@rerobika rerobika rerobika approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rtakacs @rerobika @akosthekiss @LaszloLango