Compile with clang-7.0 #2754
Merged
Compile with clang-7.0 #2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Well, I messed this one up, too. |
Member
|
@wille-io You don't have to close a PR just because a fix didn't work out. (Unless you give up on the fix completely.) You can just keep working on the same branch and push / force push it to GitHub. It will update the PR automatically. It is a better approach than opening a new PR for every try. Please see the GitHub Flow intro (section "Discuss and review your code"). |
Contributor
Author
|
@akosthekiss Can we please have a talk about me failing git @ irc? Sadly nobody was answering there for several days. |
jerry_debugger_scope_variable_type_t was not explicitly sized by the compiler as 8bit, accept uint8_t instead (you still can call the fn with a jerry_debugger_scope_variable_type_t) JerryScript-DCO-1.0-Signed-off-by: wille-io mike@wille.io
Contributor
Author
|
reopen |
wille-io
force-pushed
the
clang-7.0-fix
branch
from
3fea62c to
1a80416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next try.
jerry_debugger_scope_variable_type_twas not explicitly sized by the compiler as 8bit.Instead the fn could accept a
uint8_t. You still can call the fn with a jerry_debugger_scope_variable_type_t as parameter.