Separate the debugger-client to support the later usage of other communication protocols #2764
Conversation
zherczeg
left a comment
zherczeg
left a comment
There was a problem hiding this comment.
Nice patch! Only one minor comment fix.
jerry-debugger/jerry_client_tcp.py
Outdated
| return self.socket.send(data) | ||
|
|
||
| def ready(self): | ||
| """ Monitor the file descriptor, return weither it became ready for the I/O operations or not. """ |
There was a problem hiding this comment.
I think this should only be used with receive_data, so the comment is not exactly right.
jerry-debugger/jerry_client_tcp.py
Outdated
| if self.socket not in result: | ||
| return False | ||
|
|
||
| return True |
There was a problem hiding this comment.
I think you can use return self.socket in result here.
There was a problem hiding this comment.
Indeed, good catch. :)
…unication protocols JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
separate_communcation_layers
branch
from
5ec6ecb to
d3e01be
Compare
| WEBSOCKET_FIN_BIT = 0x80 | ||
|
|
||
| class WebSocket(object): | ||
| def __init__(self, address, protocol=Socket()): |
There was a problem hiding this comment.
Using the Socket() as default argument is not correct. The protocol will have a reference to the created object and if the WebSocket is constructed multiple times the same socket will be used in both cases.
example.:
a = WebSocket()
b = WebSocket()
a.protocol == b.protocol
We should use None as default and add an check in the constructor to create the socket object.
| self.data_buffer += self.protocol.receive_data() | ||
|
|
||
| if self.data_buffer[0:len_expected] != expected: | ||
| raise Exception("Unexpected handshake") |
There was a problem hiding this comment.
In the future it would be good to have specialized Exception classes so we can catch our module's exceptions in a uniform fashion and would make it possible to distinguish between the "base" exceptions ans our exceptions.
There was a problem hiding this comment.
This applies to all exceptions in this PR.
5 participants
No description provided.