Ensure that Symbol.toStringTag property is copied to buffer as a cesu8 string #2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
force-pushed
the
fix_issue_2769
branch
from
752afe7 to
7842275
Compare
LaszloLango
requested changes
Feb 25, 2019
| /* Copy to buffer the #@@toStringTag# string */ | ||
| buffer_ptr += ecma_string_copy_to_utf8_buffer (tag_str_p, buffer_ptr, | ||
| buffer_ptr += ecma_string_copy_to_cesu8_buffer (tag_str_p, buffer_ptr, | ||
| (lit_utf8_size_t) ((str_buffer + buffer_size) - buffer_ptr)); |
rerobika
force-pushed
the
fix_issue_2769
branch
from
7842275 to
cfc51bf
Compare
dbatyai
requested changes
Mar 6, 2019
Member
dbatyai
left a comment
dbatyai
left a comment
There was a problem hiding this comment.
Please fix the commit message to refer to the correct issue. (2759->2769)
…8 string This path fixes jerryscript-project#2769. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
Member
Author
|
@dbatyai Thanks for the review I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #2769.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu