Make jerryx_port_handler_print_char truly a port function #2789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
reviewed
Mar 6, 2019
jerry-port/default/default-io.c
Outdated
| void | ||
| jerry_port_print_char (char c) /**< the character to print */ | ||
| { | ||
| printf ("%c", c); |
Member
There was a problem hiding this comment.
Since the purpose of this function is to print a single character, would it make sense to use putchar? Could that make a difference?
Contributor
Author
There was a problem hiding this comment.
I'm not against it, currently I've just moved the original implementation. AFAIK if there is a printf on a port, the putchar should also be there. So it should not change anything. Should I change it to putchar?
Contributor
There was a problem hiding this comment.
Both printf and putchar are good to me.
Member
There was a problem hiding this comment.
I think putchar would be preferable here, but if you feel that it's outside of the scope of this change, then I won't insist.
In the previous approach `jerryx_port_handler_print_char` was implemented in by the jerry-default-port. This implementation however required the jerry-ext handler header file which created a requirement in the jerry-default-port for the jerry-ext headers. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
galpeter
force-pushed
the
port_print_char
branch
from
ce260ab to
0925184
Compare
Contributor
Author
|
@dbatyai I've updated the PR. Now the putchar is used in the default port |
dbatyai
approved these changes
Mar 13, 2019
Member
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous approach
jerryx_port_handler_print_charwas implementedin by the jerry-default-port. This implementation however required the
jerry-ext handler header file which created a requirement for the
jerry-default-port for the jerry-ext headers.