[Part II] Implement ES2015 module system #2792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
requested changes
Mar 21, 2019
Contributor
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
Please rebase to the current master
LaszloLango
requested changes
Apr 23, 2019
| struct ecma_module *next_p; /**< next linked list node */ | ||
| ecma_module_state_t state; /**< state of the mode */ | ||
| ecma_string_t *path_p; /**< path of the module */ | ||
| ecma_module_context_t *context_p; /**< module context of the module */ |
Contributor
There was a problem hiding this comment.
I do not like this kind of cycling reference. Why is this necessary?
Member
There was a problem hiding this comment.
It's not necessary in the strict sense of the word, but it's very useful for not having to look up which module the current context belongs to when connecting properties.
rerobika
requested changes
Apr 23, 2019
LaszloLango
requested changes
Apr 24, 2019
Co-authored-by: Dániel Bátyai <dbatyai@inf.u-szeged.hu> JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai@inf.u-szeged.hu JerryScript-DCO-1.0-Signed-off-by: Daniel Vince vinced@inf.u-szeged.hu
This was referenced Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 2nd part of the ES2015 module system implementation. Depends on the Part I.
Additional features to the Part I: