Allow the port to allocate/deallocate the heap #946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2016 16:26
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com
This is a first step towards pushing the Jerryscript state into objects the port can allocate and clear as opposed to static memory. JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com
LaszloLango
added
the
memory management
| /** | ||
| * Target port functions for memory management | ||
| */ | ||
| mem_heap_t *jerry_port_init_heap (void); |
Member
There was a problem hiding this comment.
I think we should add a size argument to this function. At least the implementation can check the size.
LaszloLango
added
the
jerry-port
Member
Member
|
The infrastructure for adding new heap models are available, but I think this PR is too old, and new ones should be opened for adding new heap models. Feel free to reopen it if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #945, which should be reviewed first.
See 10a1bb5 for the description & changes specific to this PR.