Use port APIs instead of printf in non-debug code #956
Conversation
|
|
||
| printf ("\\u%02x%02x", byte_high, byte_low); | ||
| jerry_port_putchar (byte_high); | ||
| jerry_port_putchar (byte_low); |
There was a problem hiding this comment.
working on fixing this (see comments in #945)
franc0is
force-pushed
the
jerry-port-not-printf
branch
2 times, most recently
from
d5b3840 to
79ce295
Compare
| sprintf(out_buf, "%02x%02x", byte_high, byte_low); | ||
|
|
||
| jerry_port_putchar ('\\'); | ||
| jerry_port_putchar ('u'); |
There was a problem hiding this comment.
I don't love this, but it's the simplest way to achieve what I am trying to achieve without adding more port APIs.
franc0is
force-pushed
the
jerry-port-not-printf
branch
from
79ce295 to
f471c2b
Compare
|
I think that's all the review comments |
franc0is
force-pushed
the
jerry-port-not-printf
branch
3 times, most recently
from
91f49c2 to
b40b489
Compare
| jerry_port_putchar ('\\'); | ||
| jerry_port_putchar ('u'); | ||
| // print high byte | ||
| char out_buf[3]; |
There was a problem hiding this comment.
Looks like neither itoa nor sprintf is implemented in jerry-libc. What's the recommended solution here, I would happily add an itoa implementation.
franc0is
force-pushed
the
jerry-port-not-printf
branch
from
b40b489 to
515e889
Compare
|
Added a simple implementation of itoa. I don't think the end result is super elegant, but I couldn't come up with anything better that didn't involve more port APIs and pulling in an implementation of sprintf. |
| * Convert an integer to a string using base and write the result to buffer. | ||
| */ | ||
| char * | ||
| itoa (int value, char *buffer, int base) |
There was a problem hiding this comment.
This implementation is not quite complete. It doesn't add the - sign for negative numbers and only accepts bases <= 16; but it is good enough for this use case.
franc0is
force-pushed
the
jerry-port-not-printf
branch
3 times, most recently
from
2b8f5c8 to
2194f0e
Compare
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com
franc0is
force-pushed
the
jerry-port-not-printf
branch
from
2194f0e to
ab4c3a5
Compare
|
Let's close this PR, because it is inactive in a long time and #1205 made this change. |
4 participants
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com