File suggestion not working

[JoyceBabu]

Describe the bug

When I try to filter by path by pressing ctrl+s, I am not able to see a files list. But if I switch to a different (smaller) repository, it works. I tried running lazygit with the --debug flag and I can see the following error logged, when I press ctrl-s.

|ERRO| ignoring create popup panel because a popup panel is already open

To Reproduce
Steps to reproduce the behavior:

1. Open lazygit
2. Press ctrl-s

Expected behavior

Fuzzy file suggestion to work in all repositories.

Screenshots
If applicable, add screenshots to help explain your problem.

Version info:

commit=, build date=, build source=homebrew, version=0.38.2, os=darwin, arch=amd64, git version=2.40.1
git version 2.40.1

Additional context

The file loading fails for a large repository, but works on small repositories.

On Large Repository

May 18 20:16:35 |DEBU| using cache for key status.showUntrackedFiles
May 18 20:16:35 |DEBU| RunCommand command="git status --untracked-files=all --porcelain -z"
May 18 20:16:35 |INFO| refreshing all scopes in async mode
May 18 20:16:35 |ERRO| ignoring create popup panel because a popup panel is already open
May 18 20:16:35 |DEBU| RunCommand command="git merge-base \"HEAD\" \"HEAD\"@{u}"
May 18 20:16:35 |DEBU| RunCommand command="git tag --list -n --sort=-creatordate"
May 18 20:16:35 |DEBU| RunCommand command="git branch -r"
May 18 20:16:35 |DEBU| RunCommand command="git stash list -z --pretty='%gs'"
May 18 20:16:35 |DEBU| using cache for key status.showUntrackedFiles
May 18 20:16:35 |DEBU| RunCommand command="git status --untracked-files=all --porcelain -z"
May 18 20:16:35 |DEBU| RunCommand command="git for-each-ref --sort=-committerdate --format=\"%(HEAD)%00%(refname:short)%00%(upstream:short)%00%(upstream:track)\" refs/heads"
May 18 20:16:35 |DEBU| RunCommand command="git symbolic-ref --short HEAD"
May 18 20:16:35 |DEBU| RunCommand command="git merge-base \"HEAD\" \"master\""
May 18 20:16:36 |DEBU| using cache for key status.showUntrackedFiles
May 18 20:16:36 |DEBU| RunCommand command="git status --untracked-files=all --porcelain -z"

On small repository

May 18 20:15:35 |DEBU| using cache for key status.showUntrackedFiles
May 18 20:15:35 |DEBU| RunCommand command="git status --untracked-files=all --porcelain -z"
May 18 20:15:36 |DEBU| using cache for key status.showUntrackedFiles
May 18 20:15:36 |DEBU| RunCommand command="git status --untracked-files=all --porcelain -z"

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

[mark2185]

When I try to filter by path by pressing ctrl+s, I am not able to see a files list

Does nothing appear or is it just empty?

[JoyceBabu]

The search popup does appear, but the files list is empty and shows no suggestions.

Also, I don't see the loading file suggestions status message.

[mark2185]

Does this still happen on the latest version?

[JoyceBabu]

The issue is present on v0.40.2

[austen-aer]

The issue is present on v0.53.0

[stefanhaller]

It seems that the function to list all files in the repo returns an error; but we can't show an error popup because our framework only allows one popup at a time (hence the "|ERRO| ignoring create popup panel because a popup panel is already open" log entry). Unfortunately we don't log what the actual error is.

If one of you folks who can reproduce it (I can't) want to debug it, this should be easy: set breakpoints at the two return err statements (here and here) in GetFilePathSuggestionsFunc and see which one you hit, and what the error is.

[JoyceBabu]

I tried debugging as you suggested and noticed that the callback passed to ignore.Walk is called only once with path = ".".

So I tried removing my .gitignore file and lazygit the file suggestion started working.

My .gitignore has a default rule to ignore all directories and files in the root path, except for a few allowed directories. gitignore.FromGit() is not handling this correctly.

# .gitignore

# Ignore by default
/*
/*/

# Whitelist specific directories
!/public/
!/src/
!/tests/
!/translations/

*.log
.DS_Store
Thumbs.db

[stefanhaller]

@JoyceBabu Thanks for debugging. So this is a bug in an upstream dependency of ours. It's interesting that Jesse forked that repo back in 2021 to fix a bug that sounds related (see iriri/minimal@dc98890), maybe that fix wasn't complete enough. I don't feel like debugging this to be honest, when the upstream repo hasn't been maintained for 7 years, and its readme describes itself as "Worse versions of packages that already exist."

But I also wonder why we are walking the file system at all, and then have to use gitignore to filter out stuff. It seems to me that a call to git ls-files should achieve the same which much simpler code, and likely even be faster. I'll play with this as soon as I find some time.

[stefanhaller]

Here's a draft PR, please test: #5056. As I suspected, this makes it much faster too.

@austen-aer, can you confirm that a similar .gitignore setup was the reason in your case too? Can you also test the PR please?

[austen-aer]

I deleted all .git* files including .gitmodules but this didn't work. However, I can confirm that the PR works!

[JoyceBabu]

The latest PR worked with my .gitignore and was noticeably faster too. Thank you.