lazygit in Portrait Mode

[surmann]

I use lazygit on a screen in portrait mode instead of the standard landscape mode. Is it possible to arrange the panels for screens in portrait mode in a different way? For example, I would like to have the left panes above the right one. This should be able to configure via a flag in the config file.

What do you think?

[jesseduffield]

I'm open to the idea, and it probably wouldn't be too hard to implement. For what it's worth I've recently merged a PR that splits the main panel vertically when the width of the window is sufficiently small:

Would you be able to provide a brief sketch of how you would like the panels arranged?

[surmann]

Currently, it looks like this:

An idea is, to switch to something like this:

Probably, the sizing is not optimal or it makes sense to put "Stash" under "Files". That depends on how much stuff you see in the different panels.

What do you think?

[jesseduffield]

I think that looks good. It might be a little awkward for the left/right arrow keys to now flick through the panels both horizontally and vertically but otherwise I think it's fine.

This would actually be a relatively easy change to implement: all the code for laying out the side panels currently lives in the layout method in gui.go. It would just need to read the config variable and then change the layout accordingly. Admittedly that layout method is getting a little hairy but I think it shouldn't be too hard to accomodate. Would you be willing to put up a PR for this?

[surmann]

I would. Unfortunately, I don't have any glue about Go, which makes it a bit harder for me.
When I find some time, I can give it a try.

[eproxus]

Idea: add visual "tabs" for the 1-5 views, and then do two panels one above the other (like the second screen mode except horizontal instead of vertical). The "tabs" could be used in the second and third screen mode too.

I'm using a 80 character wide terminal because of my small screen (editor on the left) and would love a proper portrait mode!

[jesseduffield]

@eproxus I'm not quite sure what you were describing, but I've got a PR #847 up that looks like this for 80 character width:

[jesseduffield]

also @surmann , here's what your design looks like when implemented:

The main concern I have with it is that you need the window to be quite wide to fit all the panels at the top there without them being too horizontally squished. Is that how you intend on using portrait mode?

[surmann]

@jesseduffield Yes, that looks good. But I share your concerns. Is it possible to test on a rotated screen? Any ideas to handle this?

[jesseduffield]

@surmann I myself don't use a rotated screen but if you do, you can clone this repo and checkout the branch test-portrait-mode to see how it works on your end. To run it you simply go go run main.go in the root directory of the repo

[jesseduffield]

Also here is a pick of normal lazygit with a portrait monitor:

Here it is in portrait mode:

tbh I the prefer regular layout

[surmann]

When I compare your two screenshots I see it in the same way you do.
I will try it when I am in the office.

[eproxus]

@jesseduffield That PR looks close to what I was imagining. I had in mind something like this:

┌─[Status] ─ Files ─ Branches ─ Commits ─ Stash ───────────────────────────────┐
│↑0↓0 ...                                                                      │
└──────────────────────────────────────────────────────────────────────────────┘
┌──────────────────────────────────────────────────────────────────────────────┐
│   _                       _ _                                                │
│  | |                     (_) |                                               │
│  | | __ _ _____   _  __ _ _| |_                                              │
│  | |/ _` |_  / | | |/ _` | | __|                                             │
│  | | (_| |/ /| |_| | (_| | | |_                                              │
│  |_|\__,_/___|\__, |\__, |_|\__|                                             │
│                __/ | __/ |                                                   │
│               |___/ |___/                                                    │
│ ...                                                                          │
└──────────────────────────────────────────────────────────────────────────────┘

Where the top box would switch between the 1-5 views just like in the existing vertical view today.

[surmann]

I would like to have more horizontal space when working on files line by line. In this case the "Changes" pane splits into two panes with half of the horizontal space.