fix: read one line before resuming TUI to prevent unintentional operations #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the late review. I've just rebased this onto master and tested it. Works well. Not sure how to resolve the issue where enter is pressed inbetween other characters but this PR is an improvement upon the current logic |
|
Note to self: merge after tests pass |
jesseduffield
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1629.
I can't find any way to empty stdin buffer, so this PR fixes only inputs with no extra newlines.
e.g: typing
zzzzzP<Enter>while processing commit is safe, but<Enter>zzzzzP<Enter><Enter>may cause big disaster.