Refactor: one context per view #2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseduffield
force-pushed
the
one-context-per-view
branch
4 times, most recently
from
d15502f to
c8b590a
Compare
jesseduffield
force-pushed
the
one-context-per-view
branch
5 times, most recently
from
033b304 to
e2a0e87
Compare
jesseduffield
force-pushed
the
one-context-per-view
branch
from
e2a0e87 to
54fb730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently doing some serious yak-shaving: in order to make my new filtering feature fast I need to change how views render their contents, but to make that work I need to ditch the idea of having multiple contexts sharing the one view. This PR has us creating some new views so that we can have a single context per view. In a future PR I'll clean things up some more so that the contexts actually create the views themselves
This PR also moves our staging and patch building code into a controller, and in a future PR I'll also move the merging code into a controller.