Skip to content

Conversation

@jtraub
Copy link
Contributor

@jtraub jtraub commented Aug 24, 2022

  • PR Description

This PR fixes #2131.

Here I just replaced .* with less greedy [^/] in the default https remote url regex. Domain name can not include slashes so it is safe to use this matcher.

Test suite checked SSH Gitlab urls and they worked fine but there were no check for https gitlab urls in the suite. So I decided to add a couple of tests for github with https remote urls just to be sure that they work properly too.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jtraub jtraub force-pushed the fix-open-gitlab-commit branch from 90adef8 to a67a08e Compare August 24, 2022 01:23
@jesseduffield jesseduffield merged commit e7aacaf into jesseduffield:master Sep 1, 2022
@jesseduffield
Copy link
Owner

Nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open in browser doesn't work for some gitlab repos

2 participants