(#2288) quote remoteName before compiling regex

[nils-a]

• PR Description

If the remote name contains special regex-chars,
the compilation of the regex might fail.
Quoting the remoteName ensures that all special chars in the remoteName are properly escaped before compiling the regex.

• Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• Docs (specifically docs/Config.md) have been updated if necessary
• You've read through your own file changes for silly mistakes etc

[nils-a]

While I feel escaping the remoteName does no harm, and it solves the issue at hand, I also feel it does not solve the root-cause.

I actually feel that no remote * should be listed here. However, I am unsure where to address this. Here or in go-git?

Any pointers would be greatly appreciated.

[jesseduffield]

Code looks good to me so I'm happy to merge as-is (great work on the integration test).

As for the root problem, good question. If the remote doesn't appear when doing a porcelain git command to list the remotes, then I think this is an issue on go-git's side