Added new gui.screenMode key to config

[phanithinks]

• PR Description
  Fix for not able to set the vertical screen mode as default  #2319
  new gui.screenMode key added to configuration

• Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

[jesseduffield]

Looks good @phanithinks . One thing: now that the user is seeing the name 'screenMode', it's worth asking: is this an intuitive name? I think 'windowSize' would be better

[phanithinks]

Looks good @phanithinks . One thing: now that the user is seeing the name 'screenMode', it's worth asking: is this an intuitive name? I think 'windowSize' would be better

Thank you @jesseduffield for reviewing. I changed as per your suggestion in configuration.

[phanithinks]

@jesseduffield Do I need to make any more changes to this pr ? Please let me know

[jesseduffield]

Sorry for the late re-review, I've left one more comment

[github-actions]

Uffizzi Preview Environment deployment-13017

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2358

📄 View Application Logs etc.

What is Uffizzi? Learn more

[jesseduffield]

Merged. Thanks for making this @phanithinks !

[mikeduminy]

Thank you! Just what I was looking for :D

One thing to note, the commands for switching between these visual modes refer to this feature as screenMode, not windowSize. To me windowSize feels like it's describing the size of the overall gui window and not the layout. I'd rather go with gui.layout or gui.defaultMainPanelSize.

[jesseduffield]

hmm if there's a time to change that it would be now. I actually think gui.focusedPanelSize makes the most sense, as that's the panel that would be resized. It is a shame we just released this haha, meaning we'd have to be backwards compatible