Skip to content

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Feb 23, 2023

  • PR Description

Migrates the staging panel integration tests.

We need some better constructs for working with the staging panel, like being able to do assertions on the range of selected lines. We'll also need that for when we add the bulk actions feature. For now, I'm just sticking to the testing constructs we already have, with the focus being on moving away from the legacy pattern. But we'll need to come back and fix up this new tech debt.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

Uffizzi Preview Environment deployment-17203

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2470

📄 View Application Logs etc.

What is Uffizzi? Learn more

@jesseduffield jesseduffield merged commit 752526c into master Feb 23, 2023
@jesseduffield jesseduffield deleted the migrate-staging-tests branch February 23, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants