Fix accordion mode when building a custom patch #2481
Conversation
pkg/gui/arrangement.go
Outdated
| if ctx.GetKind() == types.SIDE_CONTEXT { | ||
| return ctx.GetWindowName() | ||
| } else if ctx.GetKey() == context.PATCH_BUILDING_MAIN_CONTEXT_KEY { | ||
| return "commits" |
There was a problem hiding this comment.
I have no idea if this is an appropriate way to fix it, to be honest. It seems to work for me. 😄
There was a problem hiding this comment.
I'm surprised the original code isn't working: there should be some side context in the context stack, and I'd expect to see the a context in there belonging to the commits window, given you had to go through the commits window to reach the patch building window. I'd like to find the root cause of the issue before we add something this specific to this file
There was a problem hiding this comment.
Ok, I dropped this and pushed a new commit that looks more like the appropriate fix to me. Please have a look.
I still don't have enough overview over how things play together to tell whether this might have broken something else.
There was a problem hiding this comment.
We've got enough integration tests for these things that I'm pretty confident we haven't broken anything, and if we stumble across a problem we can add a test for it and revisit
Uffizzi Preview Environment
|
This fixes accordion mode for the commit files panel. When entering a file, the commit files panel should stay expanded.
stefanhaller
force-pushed
the
fix-accordion-mode-for-custom-patch
branch
from
3cf458d to
723504a
Compare
|
Nice, this is a much better fix. Great work |
2 participants
When
gui.expandFocusedSidePanelis set, the commits panel should be expanded while building a custom patch. However, the files panel was expanded in this case. This PR fixes that.go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary