Fix issues with commit message panel losing focus #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where if you're focused on the commit message panel, then say an error panel pops up, the commit message panel goes to the back of the views but then focus is returned to it
Now we just bring that panel to the front when it's focused.
But while fixing this bug I also decided to introduce the idea of not ever returning focus to 'second class panels' which currently just contains the confirmation panel.
Can be tested with this: