Fix: no-alias-methods supports .resolves & .rejects #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does this cover |
SimenB
requested changes
Dec 4, 2018
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Code in this PR looks great, but I'd like to see a test for expect(a).not.toThrowError() as well
Contributor
Author
|
Added, thanks for the feedback @SimenB. |
SimenB
approved these changes
Dec 4, 2018
Member
|
Thank you! |
Member
|
🎉 This PR is included in version 22.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autofix for
no-alias-methodsdidn't catch everything it could've in our internal repo. Specifically.resolves&.rejectswere missed.This PR assumes that the full list of
methodNamescan be prefixed with.resolvesand.rejects.There may be other helpers I've overlooked that could be added here. For now, I erred on the side of caution.