fix: use range instead of start/end properties #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Feb 1, 2019
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Thanks!
This seems like something that should be part of https://www.npmjs.com/package/eslint-plugin-eslint-plugin, so we don't re-introduce it in the future...
Member
|
🎉 This PR is included in version 22.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
LordParsley
added a commit
to LordParsley/eslint-plugin-sort-class-members
that referenced
this pull request
Dec 18, 2019
A similar issue here typescript-eslint/typescript-eslint#175 -> jest-community/eslint-plugin-jest#221 explains how `range` should be used as per https://eslint.org/docs/developer-guide/working-with-custom-parsers#all-nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usage of non standard fields
start,endwithrange.Properties
start,endshould not be used (they may be removed in feature)currently those rules are crashing because of that if you decide to use (@typescript-eslint/parser)
see: https://eslint.org/docs/developer-guide/working-with-custom-parsers#all-nodes
fixes: typescript-eslint/typescript-eslint#175