Skip to content

fix(jest-changed-files): avoid crashing if the sl command is taken by Steam Locomotive instead of Sapling #14061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(jest-changed-files): avoid crashing if the sl command is taken by Steam Locomotive instead of Sapling #14061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28b3f03
fix(jest-changed-files): avoid waiting for Steam Locomotive
mrazauskas Apr 7, 2023
b88452f
change log entry
mrazauskas Apr 7, 2023
e1c8911
restart ci
mrazauskas Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- `[jest-changed-files]` Avoid crashing if the `sl` command is taken by Steam Locomotive instead of Sapling ([#14061](https://github.com/facebook/jest/pull/14061))
- `[jest-config]` Handle frozen config object ([#14054](https://github.com/facebook/jest/pull/14054))
- `[jest-environment-jsdom, jest-environment-node]` Fix assignment of `customExportConditions` via `testEnvironmentOptions` when custom env subclass defines a default value ([#13989](https://github.com/facebook/jest/pull/13989))
- `[jest-matcher-utils]` Fix copying value of inherited getters ([#14007](https://github.com/facebook/jest/pull/14007))
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-changed-files/src/sl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const adapter: SCMAdapter = {

getRoot: async cwd => {
try {
const result = await execa('sl', ['root'], {cwd, env});
const result = await execa('sl', ['root'], {cwd, env, timeout: 250});

return result.stdout;
} catch {
Expand Down