Skip to content

[runx] Install should return paths #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2023
Merged

[runx] Install should return paths #150

merged 2 commits into from
Sep 20, 2023

Conversation

@mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Sep 19, 2023

Summary

Stacked on #149

runx.Install should return the path where binaries are installed.

In the future I think we can make this API a bit better by making it typed. e.g.

runx.install(git.Repo{
  Provider: git.GithubProvider,
  User:     "jetpack-io",
  Name:     "envsec",
})

How was it tested?

runx --install jetpack-io/envsec

Base automatically changed from landau/runx to main September 20, 2023 00:02
@mikeland73 mikeland73 merged commit 4b2f0c8 into main Sep 20, 2023
@mikeland73 mikeland73 deleted the landau/runx-2 branch September 20, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LucilleH LucilleH LucilleH approved these changes

@loreto loreto Awaiting requested review from loreto

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikeland73 @LucilleH