Adds token refresh logic #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
mikeland73
approved these changes
Sep 25, 2023
pkg/sandbox/auth/auth.go
Outdated
| if !tok.Valid() { | ||
| return nil, false | ||
| } | ||
| return tok, true |
pkg/sandbox/auth/auth.go
Outdated
| func (c *Client) RefreshSession() *session.Token { | ||
| panic("refresh session not implemented") | ||
| func (c *Client) refresh(tok *session.Token) *session.Token { | ||
| ctx := context.Background() |
| return tok | ||
| } | ||
|
|
||
| if newToken.AccessToken != tok.AccessToken { |
mikeland73
approved these changes
Sep 28, 2023
LucilleH
approved these changes
Sep 28, 2023
pkg/sandbox/auth/auth.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // TODO: figure out how to share oidc provider and outh2 client |
Contributor
|
I tested by:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds token refresh logic
How was it tested?
I'm actually unsure how best to test this other than going through the auth flow, waiting for my token to expire, and running again. Any ideas on how best to shortcut that process? Is there a way to purposefully give myself an expired token on the first try?